feat(converters): re-enable variable scripting translations#8388
Merged
vijayh-bruno merged 2 commits intoJun 29, 2026
Conversation
sanish-bruno
requested review from
bijin-bruno,
helloanoop,
lohit-bruno,
naman-bruno,
sid-bruno,
utkarsh-bruno and
vijayh-bruno
as code owners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (10)
WalkthroughPostman and Bruno variable translation tables now cover additional global and collection helper calls in both directions. Matching tests were re-enabled and expanded for direct assertions and transpiler scenarios. ChangesPostman↔Bruno variable translations
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sanish-bruno
changed the title
Contributor
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
sanish-bruno
force-pushed
the
feat/enable-api-translations
branch
from
8bf8ff6 to
62ee62e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/bruno-converters/tests/postman/postman-translations/transpiler-tests/variables.test.js`:
- Around line 109-136: Add a regression test for the newly restored
pm.globals.toObject mapping in the variables translation suite. In
variables.test.js, extend the existing translateCode coverage alongside
pm.globals.unset, pm.globals.clear, and pm.collectionVariables.toObject to
assert that pm.globals.toObject() translates to bru.getAllGlobalEnvVars(). This
should exercise the postman-to-bruno-translator.js behavior so the restored
global toObject mapping stays covered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0530a85f-18fb-47e9-a77e-636a8654d43d
📒 Files selected for processing (11)
packages/bruno-converters/src/postman/postman-translations.jspackages/bruno-converters/src/utils/bruno-to-postman-translator.jspackages/bruno-converters/src/utils/postman-to-bruno-translator.jspackages/bruno-converters/tests/bruno/bruno-to-postman-translations/variables.test.jspackages/bruno-converters/tests/postman/postman-translations/postman-comments.spec.jspackages/bruno-converters/tests/postman/postman-translations/postman-variables.spec.jspackages/bruno-converters/tests/postman/postman-translations/transpiler-tests/combined.test.jspackages/bruno-converters/tests/postman/postman-translations/transpiler-tests/multiline-syntax.test.jspackages/bruno-converters/tests/postman/postman-translations/transpiler-tests/response.test.jspackages/bruno-converters/tests/postman/postman-translations/transpiler-tests/testing-framework.test.jspackages/bruno-converters/tests/postman/postman-translations/transpiler-tests/variables.test.js
vijayh-bruno
previously approved these changes
Jun 29, 2026
…ble methods - Reintroduced translations for `setCollectionVar`, `deleteCollectionVar`, `deleteAllCollectionVars`, and their global counterparts in the Postman to Bruno and Bruno to Postman translators. - Updated tests to validate the translations for these methods, ensuring accurate functionality and consistency across variable management. - Removed outdated comments regarding UI updates, reflecting the current state of the implementation.
…als.toObject - Introduced new test cases to validate the translation of `bru.getAllGlobalEnvVars` to `pm.globals.toObject` and vice versa. - Enhanced the test suite for both Bruno to Postman and Postman to Bruno translations, ensuring comprehensive coverage for variable management methods.
sanish-bruno
force-pushed
the
feat/enable-api-translations
branch
from
62ee62e to
aeeea2a
Compare
vijayh-bruno
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enables Postman ↔ Bruno script translations that were previously commented out because the underlying runtime APIs would not propagate variable mutations to the UI tables. With variable persistence landing in #8315, these APIs now update both the request lifecycle and the UI, so the translations can be turned back on.
JIRA: BRU-3096
JIRA: BRU-3082
Important
Depends on #8315 — that PR must be merged first, otherwise the re-enabled translations will silently fail to update the UI.
Re-enabled translations
pm.globals.unsetbru.deleteGlobalEnvVarpm.globals.clearbru.deleteAllGlobalEnvVarspm.collectionVariables.setbru.setCollectionVarpm.collectionVariables.unsetbru.deleteCollectionVarpm.collectionVariables.clearbru.deleteAllCollectionVarspm.collectionVariables.toObjectbru.getAllCollectionVarsApplied in both directions and to both transformer paths:
packages/bruno-converters/src/utils/postman-to-bruno-translator.js(AST/jscodeshift)packages/bruno-converters/src/postman/postman-translations.js(regex fallback)packages/bruno-converters/src/utils/bruno-to-postman-translator.js(AST/jscodeshift)Tests
it.skip/test.skipblocks across 8 spec files covering the collection-variable APIs.pm.globals.unset,pm.globals.clear,pm.collectionVariables.clear,pm.collectionVariables.toObject, and theirbru.*reverse mappings).npm run test --workspace=packages/bruno-converters→ 71/71 suites pass, 1104 tests pass.Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Summary by CodeRabbit
New Features
set,unset,clear, and converting to object form.Tests
pm.collectionVariables.*andpm.globals.*.